nfsd4: fix change attribute endianness

J. Bruce Fields · J. Bruce Fields · commit 45eaa1c1a161 · 2012-05-31T20:29:38.000-04:00
Though actually this doesn't matter much, as NFSv4.0 clients are
required to treat the change attribute as opaque.

Signed-off-by: J. Bruce Fields &lt;bfields@redhat.com&gt;
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
@@ -1674,12 +1674,12 @@ nfsd4_decode_compound(struct nfsd4_compoundargs *argp)
 
 static void write32(__be32 **p, u32 n)
 {
-	*(*p)++ = n;
+	*(*p)++ = htonl(n);
 }
 
 static void write64(__be32 **p, u64 n)
 {
-	write32(p, (u32)(n >> 32));
+	write32(p, (n >> 32));
 	write32(p, (u32)n);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1674,12 +1674,12 @@ nfsd4_decode_compound(struct nfsd4_compoundargs *argp)`
`1674`	`1674`
`1675`	`1675`	`static void write32(__be32 **p, u32 n)`
`1676`	`1676`	`{`
`1677`		`- (p)++ = n;`
	`1677`	`+ (p)++ = htonl(n);`
`1678`	`1678`	`}`
`1679`	`1679`
`1680`	`1680`	`static void write64(__be32 **p, u64 n)`
`1681`	`1681`	`{`
`1682`		`- write32(p, (u32)(n >> 32));`
	`1682`	`+ write32(p, (n >> 32));`
`1683`	`1683`	`write32(p, (u32)n);`
`1684`	`1684`	`}`
`1685`	`1685`