wifi: ipw2x00: don't call dev_kfree_skb() under spin_lock_irqsave()

Yang Yingliang · Kalle Valo · commit 45fc6d7461f1 · 2022-12-22T18:03:10.000+02:00
It is not allowed to call kfree_skb() or consume_skb() from hardware interrupt context or with hardware interrupts being disabled. It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead. The difference between them is free reason, dev_kfree_skb_irq() means the SKB is dropped in error and dev_consume_skb_irq() means the SKB is consumed in normal. In this case, dev_kfree_skb() is called to free and drop the SKB when it's reset, so replace it with dev_kfree_skb_irq(). Compile tested only. Fixes: 43f66a6 ("Add ipw2200 wireless driver.") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20221208143826.2385218-1-yangyingliang@huawei.com
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -3427,7 +3427,7 @@ static void ipw_rx_queue_reset(struct ipw_priv *priv,
 			dma_unmap_single(&priv->pci_dev->dev,
 					 rxq->pool[i].dma_addr,
 					 IPW_RX_BUF_SIZE, DMA_FROM_DEVICE);
-			dev_kfree_skb(rxq->pool[i].skb);
+			dev_kfree_skb_irq(rxq->pool[i].skb);
 			rxq->pool[i].skb = NULL;
 		}
 		list_add_tail(&rxq->pool[i].list, &rxq->rx_used);

Original file line number	Diff line number	Diff line change
`@@ -3427,7 +3427,7 @@ static void ipw_rx_queue_reset(struct ipw_priv *priv,`
`3427`	`3427`	`dma_unmap_single(&priv->pci_dev->dev,`
`3428`	`3428`	`rxq->pool[i].dma_addr,`
`3429`	`3429`	`IPW_RX_BUF_SIZE, DMA_FROM_DEVICE);`
`3430`		`- dev_kfree_skb(rxq->pool[i].skb);`
	`3430`	`+ dev_kfree_skb_irq(rxq->pool[i].skb);`
`3431`	`3431`	`rxq->pool[i].skb = NULL;`
`3432`	`3432`	`}`
`3433`	`3433`	`list_add_tail(&rxq->pool[i].list, &rxq->rx_used);`