qed: Fix corner case for chain in-between pages

Tomer Tayar · davem330 · commit 4639d60d2bfb · 2015-12-07T14:14:03.000-05:00
The amount of chain next pointer elements between the producer
and the consumer indices depends on which pages they currently
point to. The current calculation is based only on their difference,
and it can lead to a number of free elements which is higher by 1
than the actual value.

Signed-off-by: Tomer Tayar &lt;Tomer.Tayar@qlogic.com&gt;
Signed-off-by: Manish Chopra &lt;manish.chopra@qlogic.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/include/linux/qed/qed_chain.h b/include/linux/qed/qed_chain.h
@@ -111,7 +111,8 @@ static inline u16 qed_chain_get_elem_left(struct qed_chain *p_chain)
 	used = ((u32)0x10000u + (u32)(p_chain->prod_idx)) -
 		(u32)p_chain->cons_idx;
 	if (p_chain->mode == QED_CHAIN_MODE_NEXT_PTR)
-		used -= (used / p_chain->elem_per_page);
+		used -= p_chain->prod_idx / p_chain->elem_per_page -
+			p_chain->cons_idx / p_chain->elem_per_page;
 
 	return p_chain->capacity - used;
 }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,8 @@ static inline u16 qed_chain_get_elem_left(struct qed_chain *p_chain)`
`111`	`111`	`used = ((u32)0x10000u + (u32)(p_chain->prod_idx)) -`
`112`	`112`	`(u32)p_chain->cons_idx;`
`113`	`113`	`if (p_chain->mode == QED_CHAIN_MODE_NEXT_PTR)`
`114`		`- used -= (used / p_chain->elem_per_page);`
	`114`	`+ used -= p_chain->prod_idx / p_chain->elem_per_page -`
	`115`	`+ p_chain->cons_idx / p_chain->elem_per_page;`
`115`	`116`
`116`	`117`	`return p_chain->capacity - used;`
`117`	`118`	`}`