Skip to content

Commit 480b141

Browse files
Javier Martinez CanillasWolfram Sang
authored andcommitted
i2c: Replace I2C_CROS_EC_TUNNEL dependency
The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since the platform device that is matched with the I2C bus driver is registered by the ChromeOS EC mfd driver, I2C_CROS_EC_TUNNEL really depends on MFD_CROS_EC. And because this config option selects CROS_EC_PROTO, that dependency is met as well. So make the driver to depend on MFD_CROS_EC instead of CROS_EC_PROTO. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
1 parent 2cd9fbd commit 480b141

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/i2c/busses/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1140,7 +1140,7 @@ config I2C_SIBYTE
11401140

11411141
config I2C_CROS_EC_TUNNEL
11421142
tristate "ChromeOS EC tunnel I2C bus"
1143-
depends on CROS_EC_PROTO
1143+
depends on MFD_CROS_EC
11441144
help
11451145
If you say yes here you get an I2C bus that will tunnel i2c commands
11461146
through to the other side of the ChromeOS EC to the i2c bus

0 commit comments

Comments
 (0)