tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"

elfring · gregkh · commit 48f5cde56620 · 2014-11-26T19:35:49.000-08:00
The tty_kref_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c
@@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp)
 		hvsi_send_close(pv);
 	}
 
-	if (pv->tty)
-		tty_kref_put(pv->tty);
+	tty_kref_put(pv->tty);
 	pv->tty = NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv pv, struct hvc_struct hp)`
`405`	`405`	`hvsi_send_close(pv);`
`406`	`406`	`}`
`407`	`407`
`408`		`- if (pv->tty)`
`409`		`- tty_kref_put(pv->tty);`
	`408`	`+ tty_kref_put(pv->tty);`
`410`	`409`	`pv->tty = NULL;`
`411`	`410`	`}`
`412`	`411`