page allocator: move check for disabled anti-fragmentation out of fastpath

gormanm · torvalds · commit 49255c619fbd · 2009-06-16T19:47:33.000-07:00
On low-memory systems, anti-fragmentation gets disabled as there is
nothing it can do and it would just incur overhead shuffling pages between
lists constantly.  Currently the check is made in the free page fast path
for every page.  This patch moves it to a slow path.  On machines with low
memory, there will be small amount of additional overhead as pages get
shuffled between lists but it should quickly settle.

Signed-off-by: Mel Gorman &lt;mel@csn.ul.ie&gt;
Reviewed-by: Christoph Lameter &lt;cl@linux-foundation.org&gt;
Reviewed-by: KOSAKI Motohiro &lt;kosaki.motohiro@jp.fujitsu.com&gt;
Cc: Pekka Enberg &lt;penberg@cs.helsinki.fi&gt;
Cc: Peter Zijlstra &lt;a.p.zijlstra@chello.nl&gt;
Cc: Nick Piggin &lt;nickpiggin@yahoo.com.au&gt;
Cc: Dave Hansen &lt;dave@linux.vnet.ibm.com&gt;
Cc: Lee Schermerhorn &lt;Lee.Schermerhorn@hp.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
@@ -50,9 +50,6 @@ extern int page_group_by_mobility_disabled;
 
 static inline int get_pageblock_migratetype(struct page *page)
 {
-	if (unlikely(page_group_by_mobility_disabled))
-		return MIGRATE_UNMOVABLE;
-
 	return get_pageblock_flags_group(page, PB_migrate, PB_migrate_end);
 }
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
@@ -168,6 +168,10 @@ int page_group_by_mobility_disabled __read_mostly;
 
 static void set_pageblock_migratetype(struct page *page, int migratetype)
 {
+
+	if (unlikely(page_group_by_mobility_disabled))
+		migratetype = MIGRATE_UNMOVABLE;
+
 	set_pageblock_flags_group(page, (unsigned long)migratetype,
 					PB_migrate, PB_migrate_end);
 }

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,6 @@ extern int page_group_by_mobility_disabled;`
`50`	`50`
`51`	`51`	`static inline int get_pageblock_migratetype(struct page *page)`
`52`	`52`	`{`
`53`		`- if (unlikely(page_group_by_mobility_disabled))`
`54`		`- return MIGRATE_UNMOVABLE;`
`55`		`-`
`56`	`53`	`return get_pageblock_flags_group(page, PB_migrate, PB_migrate_end);`
`57`	`54`	`}`
`58`	`55`
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,10 @@ int page_group_by_mobility_disabled __read_mostly;`
`168`	`168`
`169`	`169`	`static void set_pageblock_migratetype(struct page *page, int migratetype)`
`170`	`170`	`{`
	`171`	`+`
	`172`	`+ if (unlikely(page_group_by_mobility_disabled))`
	`173`	`+ migratetype = MIGRATE_UNMOVABLE;`
	`174`	`+`
`171`	`175`	`set_pageblock_flags_group(page, (unsigned long)migratetype,`
`172`	`176`	`PB_migrate, PB_migrate_end);`
`173`	`177`	`}`