Skip to content

Commit 493be55

Browse files
v-thakkardavem330
authored andcommitted
xen-netfront: Use setup_timer
Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e, func, da; @@ -init_timer (&e); +setup_timer (&e, func, da); -e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f7f35c0 commit 493be55

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/xen-netfront.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1560,9 +1560,8 @@ static int xennet_init_queue(struct netfront_queue *queue)
15601560
spin_lock_init(&queue->tx_lock);
15611561
spin_lock_init(&queue->rx_lock);
15621562

1563-
init_timer(&queue->rx_refill_timer);
1564-
queue->rx_refill_timer.data = (unsigned long)queue;
1565-
queue->rx_refill_timer.function = rx_refill_timeout;
1563+
setup_timer(&queue->rx_refill_timer, rx_refill_timeout,
1564+
(unsigned long)queue);
15661565

15671566
snprintf(queue->name, sizeof(queue->name), "%s-q%u",
15681567
queue->info->netdev->name, queue->id);

0 commit comments

Comments
 (0)