Skip to content

Commit 4966a69

Browse files
Niklas Casseldavem330
authored andcommitted
net: stmmac: dwmac-generic: add missing compatible strings
devicetree binding for stmmac states: - compatible: Should be "snps,dwmac-<ip_version>", "snps,dwmac" For backwards compatibility: "st,spear600-gmac" is also supported. Since dwmac-generic.c calls stmmac_probe_config_dt explicitly, another alternative would have been to remove all compatible strings other than "snps,dwmac" and "st,spear600-gmac" from dwmac-generic.c. However, that would probably do more good than harm, since when trying to figure out what hardware a certain driver supports, you usually look at the compatible strings in the struct of_device_id, and not in some function defined in a completely different file. No functional change intended. Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6357d15 commit 4966a69

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,12 @@ static int dwmac_generic_probe(struct platform_device *pdev)
7171

7272
static const struct of_device_id dwmac_generic_match[] = {
7373
{ .compatible = "st,spear600-gmac"},
74+
{ .compatible = "snps,dwmac-3.50a"},
7475
{ .compatible = "snps,dwmac-3.610"},
7576
{ .compatible = "snps,dwmac-3.70a"},
7677
{ .compatible = "snps,dwmac-3.710"},
78+
{ .compatible = "snps,dwmac-4.00"},
79+
{ .compatible = "snps,dwmac-4.10a"},
7780
{ .compatible = "snps,dwmac"},
7881
{ }
7982
};

0 commit comments

Comments
 (0)