Skip to content

Commit 4ba9c1f

Browse files
mikuintjlahtine-intel
authored andcommitted
drm/i915/gen9: Add WaInPlaceDecompressionHang
Add this workaround to prevent hang when in place compression is used. References: HSD#2135774 Cc: stable@vger.kernel.org Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent 39df919 commit 4ba9c1f

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2629,6 +2629,8 @@ struct drm_i915_cmd_table {
26292629
#define SKL_REVID_D0 0x3
26302630
#define SKL_REVID_E0 0x4
26312631
#define SKL_REVID_F0 0x5
2632+
#define SKL_REVID_G0 0x6
2633+
#define SKL_REVID_H0 0x7
26322634

26332635
#define IS_SKL_REVID(p, since, until) (IS_SKYLAKE(p) && IS_REVID(p, since, until))
26342636

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1686,6 +1686,9 @@ enum skl_disp_power_wells {
16861686

16871687
#define GEN7_TLB_RD_ADDR _MMIO(0x4700)
16881688

1689+
#define GEN9_GAMT_ECO_REG_RW_IA _MMIO(0x4ab0)
1690+
#define GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS (1<<18)
1691+
16891692
#define GAMT_CHKN_BIT_REG _MMIO(0x4ab8)
16901693
#define GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING (1<<28)
16911694

drivers/gpu/drm/i915/intel_ringbuffer.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1104,6 +1104,11 @@ static int skl_init_workarounds(struct intel_engine_cs *engine)
11041104
/* WaDisableGafsUnitClkGating:skl */
11051105
WA_SET_BIT(GEN7_UCGCTL4, GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
11061106

1107+
/* WaInPlaceDecompressionHang:skl */
1108+
if (IS_SKL_REVID(dev_priv, SKL_REVID_H0, REVID_FOREVER))
1109+
WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,
1110+
GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1111+
11071112
/* WaDisableLSQCROPERFforOCL:skl */
11081113
ret = wa_ring_whitelist_reg(engine, GEN8_L3SQCREG4);
11091114
if (ret)
@@ -1173,6 +1178,11 @@ static int bxt_init_workarounds(struct intel_engine_cs *engine)
11731178
WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
11741179
GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
11751180

1181+
/* WaInPlaceDecompressionHang:bxt */
1182+
if (IS_BXT_REVID(dev_priv, BXT_REVID_C0, REVID_FOREVER))
1183+
WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,
1184+
GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1185+
11761186
return 0;
11771187
}
11781188

@@ -1220,6 +1230,10 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine)
12201230
GEN7_HALF_SLICE_CHICKEN1,
12211231
GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
12221232

1233+
/* WaInPlaceDecompressionHang:kbl */
1234+
WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,
1235+
GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1236+
12231237
/* WaDisableLSQCROPERFforOCL:kbl */
12241238
ret = wa_ring_whitelist_reg(engine, GEN8_L3SQCREG4);
12251239
if (ret)

0 commit comments

Comments
 (0)