net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency

neuschaefer · davem330 · commit 4c1342d967cb · 2018-03-05T12:52:45.000-05:00
The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename the parameter to increase consistency. This fixes the following kernel-doc warnings: ./include/net/dst_cache.h:58: warning: Function parameter or member 'addr' not described in 'dst_cache_set_ip6' ./include/net/dst_cache.h:58: warning: Excess function parameter 'saddr' description in 'dst_cache_set_ip6' Fixes: 911362c ("net: add dst_cache support") Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/include/net/dst_cache.h b/include/net/dst_cache.h
@@ -54,7 +54,7 @@ void dst_cache_set_ip4(struct dst_cache *dst_cache, struct dst_entry *dst,
  *	local BH must be disabled.
  */
 void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
-		       const struct in6_addr *addr);
+		       const struct in6_addr *saddr);
 
 /**
  *	dst_cache_get_ip6 - perform cache lookup and fetch ipv6 source address
diff --git a/net/core/dst_cache.c b/net/core/dst_cache.c
@@ -107,7 +107,7 @@ EXPORT_SYMBOL_GPL(dst_cache_set_ip4);
 
 #if IS_ENABLED(CONFIG_IPV6)
 void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
-		       const struct in6_addr *addr)
+		       const struct in6_addr *saddr)
 {
 	struct dst_cache_pcpu *idst;
 
@@ -117,7 +117,7 @@ void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
 	idst = this_cpu_ptr(dst_cache->cache);
 	dst_cache_per_cpu_dst_set(this_cpu_ptr(dst_cache->cache), dst,
 				  rt6_get_cookie((struct rt6_info *)dst));
-	idst->in6_saddr = *addr;
+	idst->in6_saddr = *saddr;
 }
 EXPORT_SYMBOL_GPL(dst_cache_set_ip6);
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ EXPORT_SYMBOL_GPL(dst_cache_set_ip4);`
`107`	`107`
`108`	`108`	`#if IS_ENABLED(CONFIG_IPV6)`
`109`	`109`	`void dst_cache_set_ip6(struct dst_cache dst_cache, struct dst_entry dst,`
`110`		`- const struct in6_addr *addr)`
	`110`	`+ const struct in6_addr *saddr)`
`111`	`111`	`{`
`112`	`112`	`struct dst_cache_pcpu *idst;`
`113`	`113`
`@@ -117,7 +117,7 @@ void dst_cache_set_ip6(struct dst_cache dst_cache, struct dst_entry dst,`
`117`	`117`	`idst = this_cpu_ptr(dst_cache->cache);`
`118`	`118`	`dst_cache_per_cpu_dst_set(this_cpu_ptr(dst_cache->cache), dst,`
`119`	`119`	`rt6_get_cookie((struct rt6_info *)dst));`
`120`		`- idst->in6_saddr = *addr;`
	`120`	`+ idst->in6_saddr = *saddr;`
`121`	`121`	`}`
`122`	`122`	`EXPORT_SYMBOL_GPL(dst_cache_set_ip6);`
`123`	`123`