ibmvnic: Free coherent DMA memory if FW map failed

tlfalcon · davem330 · commit 4cf2ddf3e329 · 2018-05-17T14:57:19.000-04:00
If the firmware map fails for whatever reason, remember to free
up the memory after.

Signed-off-by: Thomas Falcon &lt;tlfalcon@linux.vnet.ibm.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -192,6 +192,7 @@ static int alloc_long_term_buff(struct ibmvnic_adapter *adapter,
 	if (adapter->fw_done_rc) {
 		dev_err(dev, "Couldn't map long term buffer,rc = %d\n",
 			adapter->fw_done_rc);
+		dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr);
 		return -1;
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,7 @@ static int alloc_long_term_buff(struct ibmvnic_adapter *adapter,`
`192`	`192`	`if (adapter->fw_done_rc) {`
`193`	`193`	`dev_err(dev, "Couldn't map long term buffer,rc = %d\n",`
`194`	`194`	`adapter->fw_done_rc);`
	`195`	`+ dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr);`
`195`	`196`	`return -1;`
`196`	`197`	`}`
`197`	`198`	`return 0;`