Skip to content

Commit 4dffbe0

Browse files
committed
ALSA: hda - Fix HP and Front pins of ad1988/ad1989 in ad198x_power_eapd()
In ad198x_power_eapd(), wrong pin NIDs are used for controlling EAPD for HP and Front outputs of AD1988/AD1989. These are actually same with the ones for AD1984 & co, port-A is 0x11 and port-D 0x12. Reported-by: Raymond Yau <superquad.vortex2@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent bf0be0e commit 4dffbe0

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

sound/pci/hda/patch_analog.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,10 @@ static void ad198x_power_eapd(struct hda_codec *codec)
524524
case 0x11d4184a:
525525
case 0x11d4194a:
526526
case 0x11d4194b:
527+
case 0x11d41988:
528+
case 0x11d4198b:
529+
case 0x11d4989a:
530+
case 0x11d4989b:
527531
ad198x_power_eapd_write(codec, 0x12, 0x11);
528532
break;
529533
case 0x11d41981:
@@ -533,12 +537,6 @@ static void ad198x_power_eapd(struct hda_codec *codec)
533537
case 0x11d41986:
534538
ad198x_power_eapd_write(codec, 0x1b, 0x1a);
535539
break;
536-
case 0x11d41988:
537-
case 0x11d4198b:
538-
case 0x11d4989a:
539-
case 0x11d4989b:
540-
ad198x_power_eapd_write(codec, 0x29, 0x22);
541-
break;
542540
}
543541
}
544542

0 commit comments

Comments
 (0)