Skip to content

Commit 50515af

Browse files
dwmw2torvalds
authored andcommitted
firmware: Correct dependency on CONFIG_EXTRA_FIRMWARE_DIR
When CONFIG_EXTRA_FIRMWARE_DIR gets changed, the filename in the .S file (which uses .incbin to include the binary) needs to change. When we renamed the BUILTIN_FIRMWARE_DIR option to EXTRA_FIRMWARE_DIR, we forgot to update the manual dependency in firmware/Makefile, so it was depending on a non-existent file in include/config/ Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5a86102 commit 50515af

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

firmware/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) \
136136
| $(objtree)/$$(dir %)
137137
$(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
138138
$(patsubst %,$(obj)/%.gen.S, $(fw-external-y)): %: $(wordsize_deps) \
139-
include/config/builtin/firmware/dir.h | $(objtree)/$$(dir %)
139+
include/config/extra/firmware/dir.h | $(objtree)/$$(dir %)
140140
$(call cmd,fwbin,$(fwabs)/$(patsubst $(obj)/%.gen.S,%,$@))
141141

142142
# The .o files depend on the binaries directly; the .S files don't.

0 commit comments

Comments
 (0)