Skip to content

Commit 505a314

Browse files
ozbenhmpe
authored andcommitted
powerpc: Fix HMIs on big-endian with CONFIG_RELOCATABLE=y
HMIs will crash the kernel due to BRANCH_LINK_TO_FAR(hmi_exception_realmode) Calling into the OPD instead of the actual code. Fixes: 2337d20 ("powerpc/64: CONFIG_RELOCATABLE support for hmi interrupts") Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> [mpe: Use DOTSYM() rather than #ifdef] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent f1e0add commit 505a314

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/powerpc/kernel/exceptions-64s.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1031,7 +1031,7 @@ TRAMP_REAL_BEGIN(hmi_exception_early)
10311031
EXCEPTION_PROLOG_COMMON_2(PACA_EXGEN)
10321032
EXCEPTION_PROLOG_COMMON_3(0xe60)
10331033
addi r3,r1,STACK_FRAME_OVERHEAD
1034-
BRANCH_LINK_TO_FAR(hmi_exception_realmode) /* Function call ABI */
1034+
BRANCH_LINK_TO_FAR(DOTSYM(hmi_exception_realmode)) /* Function call ABI */
10351035
cmpdi cr0,r3,0
10361036

10371037
/* Windup the stack. */

0 commit comments

Comments
 (0)