mlxsw: core: remove an unneeded condition

Dan Carpenter · davem330 · commit 515123e286b6 · 2015-12-11T20:10:55.000-05:00
We already know "err" is zero so there is no need to check.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Acked-by: Jiri Pirko &lt;jiri@mellanox.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -169,7 +169,7 @@ static ssize_t mlxsw_hwmon_pwm_store(struct device *dev,
 		dev_err(mlxsw_hwmon->bus_info->dev, "Failed to write PWM\n");
 		return err;
 	}
-	return err ? err : len;
+	return len;
 }
 
 enum mlxsw_hwmon_attr_type {

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ static ssize_t mlxsw_hwmon_pwm_store(struct device *dev,`
`169`	`169`	`dev_err(mlxsw_hwmon->bus_info->dev, "Failed to write PWM\n");`
`170`	`170`	`return err;`
`171`	`171`	`}`
`172`		`- return err ? err : len;`
	`172`	`+ return len;`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`enum mlxsw_hwmon_attr_type {`