workqueue: use put_device() instead of kfree()

ArvindYadavCs · htejun · commit 537f4146c53c · 2018-03-13T13:26:03.000-07:00
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized in this function instead. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Tejun Heo <tj@kernel.org>
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
@@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)
 
 	ret = device_register(&wq_dev->dev);
 	if (ret) {
-		kfree(wq_dev);
+		put_device(&wq_dev->dev);
 		wq->wq_dev = NULL;
 		return ret;
 	}

Original file line number	Diff line number	Diff line change
`@@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)`
`5337`	`5337`
`5338`	`5338`	`ret = device_register(&wq_dev->dev);`
`5339`	`5339`	`if (ret) {`
`5340`		`- kfree(wq_dev);`
	`5340`	`+ put_device(&wq_dev->dev);`
`5341`	`5341`	`wq->wq_dev = NULL;`
`5342`	`5342`	`return ret;`
`5343`	`5343`	`}`