kselftest/cgroup: fix a signedness bug

Dan Carpenter · Shuah Khan (Samsung OSG) · commit 53c3daf8cfea · 2018-06-07T13:44:30.000-06:00
"len" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: Shuah Khan (Samsung OSG) &lt;shuah@kernel.org&gt;
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
 	return len;
 }
 
-static ssize_t write_text(const char *path, char *buf, size_t len)
+static ssize_t write_text(const char *path, char *buf, ssize_t len)
 {
 	int fd;
 
@@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
 int cg_write(const char *cgroup, const char *control, char *buf)
 {
 	char path[PATH_MAX];
-	size_t len = strlen(buf);
+	ssize_t len = strlen(buf);
 
 	snprintf(path, sizeof(path), "%s/%s", cgroup, control);
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ static ssize_t read_text(const char path, char buf, size_t max_len)`
`35`	`35`	`return len;`
`36`	`36`	`}`
`37`	`37`
`38`		`-static ssize_t write_text(const char path, char buf, size_t len)`
	`38`	`+static ssize_t write_text(const char path, char buf, ssize_t len)`
`39`	`39`	`{`
`40`	`40`	`int fd;`
`41`	`41`
`@@ -140,7 +140,7 @@ long cg_read_key_long(const char cgroup, const char control, const char *key)`
`140`	`140`	`int cg_write(const char cgroup, const char control, char *buf)`
`141`	`141`	`{`
`142`	`142`	`char path[PATH_MAX];`
`143`		`- size_t len = strlen(buf);`
	`143`	`+ ssize_t len = strlen(buf);`
`144`	`144`
`145`	`145`	`snprintf(path, sizeof(path), "%s/%s", cgroup, control);`
`146`	`146`