aio: fix failure to put the file pointer

axboe · Al Viro · commit 53fffe29a9e6 · 2018-11-17T10:05:07.000-05:00
If the ioprio capability check fails, we return without putting the file pointer. Fixes: d9a08a9 ("fs: Add aio iopriority support") Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/fs/aio.c b/fs/aio.c
@@ -1436,6 +1436,7 @@ static int aio_prep_rw(struct kiocb *req, struct iocb *iocb)
 		ret = ioprio_check_cap(iocb->aio_reqprio);
 		if (ret) {
 			pr_debug("aio ioprio check cap error: %d\n", ret);
+			fput(req->ki_filp);
 			return ret;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1436,6 +1436,7 @@ static int aio_prep_rw(struct kiocb req, struct iocb iocb)`
`1436`	`1436`	`ret = ioprio_check_cap(iocb->aio_reqprio);`
`1437`	`1437`	`if (ret) {`
`1438`	`1438`	`pr_debug("aio ioprio check cap error: %d\n", ret);`
	`1439`	`+ fput(req->ki_filp);`
`1439`	`1440`	`return ret;`
`1440`	`1441`	`}`
`1441`	`1442`