bonding: reread information about speed and duplex when interface goes up

ole2pl · davem330 · commit 546add794681 · 2010-10-06T14:28:22.000-07:00
When an interface was enslaved when it was down, bonding thinks
it has speed -1 even after it goes up. This leads into selecting
a wrong active interface in active/backup mode on mixed 10G/1G or
1G/100M environment.

before:
 bonding: bond0: link status definitely up for interface eth5, 100 Mbps full duplex.
 bonding: bond0: link status definitely up for interface eth0, 100 Mbps full duplex.

after:
 bonding: bond0: link status definitely up for interface eth5, 10000 Mbps full duplex.
 bonding: bond0: link status definitely up for interface eth0, 1000 Mbps full duplex.

Signed-off-by: Krzysztof Piotr Oledzki &lt;ole@ans.pl&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
@@ -2406,6 +2406,8 @@ static void bond_miimon_commit(struct bonding *bond)
 				slave->state = BOND_STATE_BACKUP;
 			}
 
+			bond_update_speed_duplex(slave);
+
 			pr_info("%s: link status definitely up for interface %s, %d Mbps %s duplex.\n",
 				bond->dev->name, slave->dev->name,
 				slave->speed, slave->duplex ? "full" : "half");

Original file line number	Diff line number	Diff line change
`@@ -2406,6 +2406,8 @@ static void bond_miimon_commit(struct bonding *bond)`
`2406`	`2406`	`slave->state = BOND_STATE_BACKUP;`
`2407`	`2407`	`}`
`2408`	`2408`
	`2409`	`+ bond_update_speed_duplex(slave);`
	`2410`	`+`
`2409`	`2411`	`pr_info("%s: link status definitely up for interface %s, %d Mbps %s duplex.\n",`
`2410`	`2412`	`bond->dev->name, slave->dev->name,`
`2411`	`2413`	`slave->speed, slave->duplex ? "full" : "half");`