Skip to content

Commit 5473a7b

Browse files
Vasundhara Volamdavem330
Vasundhara Volam
authored and
davem330
committed
devlink: Add support for driverinit set value for devlink_port
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_set() function to help the driver set the value to devlink_port. Also, move the common code to __devlink_param_driverinit_value_set() to be used by both device and port params. v7->v8: Re-order the definitions as follows: __devlink_param_driverinit_value_get __devlink_param_driverinit_value_set devlink_param_driverinit_value_get devlink_param_driverinit_value_set devlink_port_param_driverinit_value_get devlink_port_param_driverinit_value_set Cc: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ffd19b9 commit 5473a7b

File tree

2 files changed

+63
-18
lines changed

2 files changed

+63
-18
lines changed

‎include/net/devlink.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,9 @@ int
582582
devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port,
583583
u32 param_id,
584584
union devlink_param_value *init_val);
585+
int devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,
586+
u32 param_id,
587+
union devlink_param_value init_val);
585588
void devlink_param_value_changed(struct devlink *devlink, u32 param_id);
586589
void devlink_param_value_str_fill(union devlink_param_value *dst_val,
587590
const char *src);
@@ -839,6 +842,14 @@ devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port,
839842
return -EOPNOTSUPP;
840843
}
841844

845+
static inline int
846+
devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,
847+
u32 param_id,
848+
union devlink_param_value init_val)
849+
{
850+
return -EOPNOTSUPP;
851+
}
852+
842853
static inline void
843854
devlink_param_value_changed(struct devlink *devlink, u32 param_id)
844855
{

‎net/core/devlink.c

Lines changed: 52 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4737,6 +4737,32 @@ __devlink_param_driverinit_value_get(struct list_head *param_list, u32 param_id,
47374737
return 0;
47384738
}
47394739

4740+
static int
4741+
__devlink_param_driverinit_value_set(struct devlink *devlink,
4742+
struct list_head *param_list, u32 param_id,
4743+
union devlink_param_value init_val,
4744+
enum devlink_command cmd)
4745+
{
4746+
struct devlink_param_item *param_item;
4747+
4748+
param_item = devlink_param_find_by_id(param_list, param_id);
4749+
if (!param_item)
4750+
return -EINVAL;
4751+
4752+
if (!devlink_param_cmode_is_supported(param_item->param,
4753+
DEVLINK_PARAM_CMODE_DRIVERINIT))
4754+
return -EOPNOTSUPP;
4755+
4756+
if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)
4757+
strcpy(param_item->driverinit_value.vstr, init_val.vstr);
4758+
else
4759+
param_item->driverinit_value = init_val;
4760+
param_item->driverinit_value_valid = true;
4761+
4762+
devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW);
4763+
return 0;
4764+
}
4765+
47404766
/**
47414767
* devlink_param_driverinit_value_get - get configuration parameter
47424768
* value for driver initializing
@@ -4774,24 +4800,10 @@ EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_get);
47744800
int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
47754801
union devlink_param_value init_val)
47764802
{
4777-
struct devlink_param_item *param_item;
4778-
4779-
param_item = devlink_param_find_by_id(&devlink->param_list, param_id);
4780-
if (!param_item)
4781-
return -EINVAL;
4782-
4783-
if (!devlink_param_cmode_is_supported(param_item->param,
4784-
DEVLINK_PARAM_CMODE_DRIVERINIT))
4785-
return -EOPNOTSUPP;
4786-
4787-
if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)
4788-
strcpy(param_item->driverinit_value.vstr, init_val.vstr);
4789-
else
4790-
param_item->driverinit_value = init_val;
4791-
param_item->driverinit_value_valid = true;
4792-
4793-
devlink_param_notify(devlink, param_item, DEVLINK_CMD_PARAM_NEW);
4794-
return 0;
4803+
return __devlink_param_driverinit_value_set(devlink,
4804+
&devlink->param_list,
4805+
param_id, init_val,
4806+
DEVLINK_CMD_PARAM_NEW);
47954807
}
47964808
EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_set);
47974809

@@ -4820,6 +4832,28 @@ int devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port,
48204832
}
48214833
EXPORT_SYMBOL_GPL(devlink_port_param_driverinit_value_get);
48224834

4835+
/**
4836+
* devlink_port_param_driverinit_value_set - set value of configuration
4837+
* parameter for driverinit
4838+
* configuration mode
4839+
*
4840+
* @devlink_port: devlink_port
4841+
* @param_id: parameter ID
4842+
* @init_val: value of parameter to set for driverinit configuration mode
4843+
*
4844+
* This function should be used by the driver to set driverinit
4845+
* configuration mode default value.
4846+
*/
4847+
int devlink_port_param_driverinit_value_set(struct devlink_port *devlink_port,
4848+
u32 param_id,
4849+
union devlink_param_value init_val)
4850+
{
4851+
return __devlink_param_driverinit_value_set(devlink_port->devlink,
4852+
&devlink_port->param_list,
4853+
param_id, init_val, 0);
4854+
}
4855+
EXPORT_SYMBOL_GPL(devlink_port_param_driverinit_value_set);
4856+
48234857
/**
48244858
* devlink_param_value_changed - notify devlink on a parameter's value
48254859
* change. Should be called by the driver

0 commit comments

Comments
 (0)