arcnet: com90xx: add __init attribute

JuliaLawall · davem330 · commit 553bc087caf0 · 2016-04-19T20:17:45.000-04:00
Add __init attribute on a function that is only called from other __init
functions and that is not inlined, at least with gcc version 4.8.4 on an
x86 machine with allyesconfig.  Currently, the function is put in the
.text.unlikely segment.  Declaring it as __init will cause it to be put in
the .init.text and to disappear after initialization.

The result of objdump -x on the function before the change is as follows:

0000000000000000 l     F .text.unlikely 00000000000000bf check_mirror

And after the change it is as follows:

0000000000000000 l     F .init.text	00000000000000ba check_mirror

Done with the help of Coccinelle.  The semantic patch checks for local
static non-init functions that are called from an __init function and are
not called from any other function.

Signed-off-by: Julia Lawall &lt;Julia.Lawall@lip6.fr&gt;
Acked-by: Michael Grzeschik &lt;mgr@pengutronix.de&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/arcnet/com90xx.c b/drivers/net/arcnet/com90xx.c
@@ -433,7 +433,7 @@ static void __init com90xx_probe(void)
 	kfree(iomem);
 }
 
-static int check_mirror(unsigned long addr, size_t size)
+static int __init check_mirror(unsigned long addr, size_t size)
 {
 	void __iomem *p;
 	int res = -1;

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ static void __init com90xx_probe(void)`
`433`	`433`	`kfree(iomem);`
`434`	`434`	`}`
`435`	`435`
`436`		`-static int check_mirror(unsigned long addr, size_t size)`
	`436`	`+static int __init check_mirror(unsigned long addr, size_t size)`
`437`	`437`	`{`
`438`	`438`	`void __iomem *p;`
`439`	`439`	`int res = -1;`