Skip to content

Commit 55ff8cf

Browse files
jwrdegoedegregkh
authored andcommitted
USB: uas: Reduce can_queue to MAX_CMNDS
The uas driver can never queue more then MAX_CMNDS (- 1) tags and tags are shared between luns, so there is no need to claim that we can_queue some random large number. Not claiming that we can_queue 65536 commands, fixes the uas driver failing to initialize while allocating the tag map with a "Page allocation failure (order 7)" error on systems which have been running for a while and thus have fragmented memory. Cc: stable@vger.kernel.org Reported-and-tested-by: Yves-Alexis Perez <corsac@corsac.net> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8835ba4 commit 55ff8cf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/storage/uas.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ static struct scsi_host_template uas_host_template = {
836836
.slave_configure = uas_slave_configure,
837837
.eh_abort_handler = uas_eh_abort_handler,
838838
.eh_bus_reset_handler = uas_eh_bus_reset_handler,
839-
.can_queue = 65536, /* Is there a limit on the _host_ ? */
839+
.can_queue = MAX_CMNDS,
840840
.this_id = -1,
841841
.sg_tablesize = SG_NONE,
842842
.skip_settle_delay = 1,

0 commit comments

Comments
 (0)