Skip to content

Commit 560f1ba

Browse files
Jakub Kicinskidavem330
authored andcommitted
nfp: use the new __netdev_tx_sent_queue() BQL optimisation
__netdev_tx_sent_queue() was added in commit e59020abf0f ("net: bql: add __netdev_tx_sent_queue()") and allows for better GSO performance. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3f2bba7 commit 560f1ba

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -890,16 +890,14 @@ static int nfp_net_tx(struct sk_buff *skb, struct net_device *netdev)
890890
u64_stats_update_end(&r_vec->tx_sync);
891891
}
892892

893-
netdev_tx_sent_queue(nd_q, txbuf->real_len);
894-
895893
skb_tx_timestamp(skb);
896894

897895
tx_ring->wr_p += nr_frags + 1;
898896
if (nfp_net_tx_ring_should_stop(tx_ring))
899897
nfp_net_tx_ring_stop(nd_q, tx_ring);
900898

901899
tx_ring->wr_ptr_add += nr_frags + 1;
902-
if (!skb->xmit_more || netif_xmit_stopped(nd_q))
900+
if (__netdev_tx_sent_queue(nd_q, txbuf->real_len, skb->xmit_more))
903901
nfp_net_tx_xmit_more_flush(tx_ring);
904902

905903
return NETDEV_TX_OK;

0 commit comments

Comments
 (0)