Skip to content

Commit 57dee99

Browse files
Laurent Pinchartdlezcano
authored andcommitted
clocksource: sh_cmt: Add clk_prepare/unprepare support
Prepare the clock at probe time, as there is no other appropriate place in the driver where we're allowed to sleep. Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
1 parent dc1ccc4 commit 57dee99

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

drivers/clocksource/sh_cmt.c

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -634,12 +634,18 @@ static int sh_cmt_clock_event_next(unsigned long delta,
634634

635635
static void sh_cmt_clock_event_suspend(struct clock_event_device *ced)
636636
{
637-
pm_genpd_syscore_poweroff(&ced_to_sh_cmt(ced)->pdev->dev);
637+
struct sh_cmt_priv *p = ced_to_sh_cmt(ced);
638+
639+
pm_genpd_syscore_poweroff(&p->pdev->dev);
640+
clk_unprepare(p->clk);
638641
}
639642

640643
static void sh_cmt_clock_event_resume(struct clock_event_device *ced)
641644
{
642-
pm_genpd_syscore_poweron(&ced_to_sh_cmt(ced)->pdev->dev);
645+
struct sh_cmt_priv *p = ced_to_sh_cmt(ced);
646+
647+
clk_prepare(p->clk);
648+
pm_genpd_syscore_poweron(&p->pdev->dev);
643649
}
644650

645651
static void sh_cmt_register_clockevent(struct sh_cmt_priv *p,
@@ -737,6 +743,10 @@ static int sh_cmt_setup(struct sh_cmt_priv *p, struct platform_device *pdev)
737743
goto err2;
738744
}
739745

746+
ret = clk_prepare(p->clk);
747+
if (ret < 0)
748+
goto err3;
749+
740750
if (res2 && (resource_size(res2) == 4)) {
741751
/* assume both CMSTR and CMCSR to be 32-bit */
742752
p->read_control = sh_cmt_read32;
@@ -773,19 +783,21 @@ static int sh_cmt_setup(struct sh_cmt_priv *p, struct platform_device *pdev)
773783
cfg->clocksource_rating);
774784
if (ret) {
775785
dev_err(&p->pdev->dev, "registration failed\n");
776-
goto err3;
786+
goto err4;
777787
}
778788
p->cs_enabled = false;
779789

780790
ret = setup_irq(irq, &p->irqaction);
781791
if (ret) {
782792
dev_err(&p->pdev->dev, "failed to request irq %d\n", irq);
783-
goto err3;
793+
goto err4;
784794
}
785795

786796
platform_set_drvdata(pdev, p);
787797

788798
return 0;
799+
err4:
800+
clk_unprepare(p->clk);
789801
err3:
790802
clk_put(p->clk);
791803
err2:

0 commit comments

Comments
 (0)