Skip to content

Commit 5ad3b03

Browse files
shimodaygregkh
authored andcommitted
usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys
This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_NO_64BIT_SUPPORT. Cc: <stable@vger.kernel.org> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0a380be commit 5ad3b03

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

drivers/usb/host/xhci-plat.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,25 @@ static const struct xhci_driver_overrides xhci_plat_overrides __initconst = {
3939

4040
static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci)
4141
{
42+
struct usb_hcd *hcd = xhci_to_hcd(xhci);
43+
4244
/*
4345
* As of now platform drivers don't provide MSI support so we ensure
4446
* here that the generic code does not try to make a pci_dev from our
4547
* dev struct in order to setup MSI
4648
*/
4749
xhci->quirks |= XHCI_PLAT;
50+
51+
/*
52+
* On R-Car Gen2 and Gen3, the AC64 bit (bit 0) of HCCPARAMS1 is set
53+
* to 1. However, these SoCs don't support 64-bit address memory
54+
* pointers. So, this driver clears the AC64 bit of xhci->hcc_params
55+
* to call dma_set_coherent_mask(dev, DMA_BIT_MASK(32)) in
56+
* xhci_gen_setup().
57+
*/
58+
if (xhci_plat_type_is(hcd, XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2) ||
59+
xhci_plat_type_is(hcd, XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3))
60+
xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
4861
}
4962

5063
/* called during probe() after chip reset completes */

0 commit comments

Comments
 (0)