Skip to content

Commit 5d0c100

Browse files
Sergei Shtylyovdavem330
authored andcommitted
ravb: kill redundant check in the probe() method
Browsing thru the driver disassembly, I noticed that gcc was able to figure out that the 'ndev' pointer is always non-NULL when calling free_netdev() on the probe() method's error path and thus skip that redundant NULL check... gcc is smart, be like gcc! :-) Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 72bca20 commit 5d0c100

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2205,8 +2205,7 @@ static int ravb_probe(struct platform_device *pdev)
22052205
if (chip_id != RCAR_GEN2)
22062206
ravb_ptp_stop(ndev);
22072207
out_release:
2208-
if (ndev)
2209-
free_netdev(ndev);
2208+
free_netdev(ndev);
22102209

22112210
pm_runtime_put(&pdev->dev);
22122211
pm_runtime_disable(&pdev->dev);

0 commit comments

Comments
 (0)