mac80211: Invoke TX LED in more code paths

andersson · jmberg-intel · commit 5d473fedd17a · 2017-05-30T09:18:13.000+02:00
ieee80211_tx_status() is only one of the possible ways a driver can
report a handled packet, some drivers call this for every packet while
others calls it rarely or never.

In order to invoke the TX LED in the non-status reporting cases this
patch pushes the call to ieee80211_led_tx() into
ieee80211_report_used_skb(), which is shared between the various code
paths.

Signed-off-by: Bjorn Andersson &lt;bjorn.andersson@linaro.org&gt;
Signed-off-by: Johannes Berg &lt;johannes.berg@intel.com&gt;
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
@@ -546,6 +546,8 @@ static void ieee80211_report_used_skb(struct ieee80211_local *local,
 		skb->wifi_acked_valid = 1;
 		skb->wifi_acked = acked;
 	}
+
+	ieee80211_led_tx(local);
 }
 
 /*
@@ -823,8 +825,6 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,
 		}
 	}
 
-	ieee80211_led_tx(local);
-
 	/* SNMP counters
 	 * Fragments are passed to low-level drivers as separate skbs, so these
 	 * are actually fragments, not frames. Update frame counters only for

Original file line number	Diff line number	Diff line change
`@@ -546,6 +546,8 @@ static void ieee80211_report_used_skb(struct ieee80211_local *local,`
`546`	`546`	`skb->wifi_acked_valid = 1;`
`547`	`547`	`skb->wifi_acked = acked;`
`548`	`548`	`}`
	`549`	`+`
	`550`	`+ ieee80211_led_tx(local);`
`549`	`551`	`}`
`550`	`552`
`551`	`553`	`/*`
`@@ -823,8 +825,6 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,`
`823`	`825`	`}`
`824`	`826`	`}`
`825`	`827`
`826`		`- ieee80211_led_tx(local);`
`827`		`-`
`828`	`828`	`/* SNMP counters`
`829`	`829`	`* Fragments are passed to low-level drivers as separate skbs, so these`
`830`	`830`	`* are actually fragments, not frames. Update frame counters only for`