ipmi: Remove incorrect use of seq_has_overflowed

JoePerches · cminyard · commit 5e33cd0c5a29 · 2015-05-05T14:24:46.000-05:00
commit d6c5dc1 ("ipmi: Remove uses of return value of seq_printf") incorrectly changed the return value of various proc_show functions to use seq_has_overflowed(). These functions should return 0 on completion rather than 1/true on overflow. 1 is the same as #define SEQ_SKIP which would cause the output to not be emitted (skipped) instead. This is a logical defect only as the length of these outputs are all smaller than the initial allocation done by the seq filesystem. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2000,7 +2000,7 @@ static int smi_ipmb_proc_show(struct seq_file *m, void *v)
 		seq_printf(m, " %x", intf->channels[i].address);
 	seq_putc(m, '\n');
 
-	return seq_has_overflowed(m);
+	return 0;
 }
 
 static int smi_ipmb_proc_open(struct inode *inode, struct file *file)
@@ -2023,7 +2023,7 @@ static int smi_version_proc_show(struct seq_file *m, void *v)
 		   ipmi_version_major(&intf->bmc->id),
 		   ipmi_version_minor(&intf->bmc->id));
 
-	return seq_has_overflowed(m);
+	return 0;
 }
 
 static int smi_version_proc_open(struct inode *inode, struct file *file)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3080,7 +3080,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)
 
 	seq_printf(m, "%s\n", si_to_str[smi->si_type]);
 
-	return seq_has_overflowed(m);
+	return 0;
 }
 
 static int smi_type_proc_open(struct inode *inode, struct file *file)
@@ -3153,7 +3153,7 @@ static int smi_params_proc_show(struct seq_file *m, void *v)
 		   smi->irq,
 		   smi->slave_addr);
 
-	return seq_has_overflowed(m);
+	return 0;
 }
 
 static int smi_params_proc_open(struct inode *inode, struct file *file)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
@@ -1200,7 +1200,7 @@ static int smi_type_proc_show(struct seq_file *m, void *v)
 {
 	seq_puts(m, "ssif\n");
 
-	return seq_has_overflowed(m);
+	return 0;
 }
 
 static int smi_type_proc_open(struct inode *inode, struct file *file)

Original file line number	Diff line number	Diff line change
`@@ -2000,7 +2000,7 @@ static int smi_ipmb_proc_show(struct seq_file m, void v)`
`2000`	`2000`	`seq_printf(m, " %x", intf->channels[i].address);`
`2001`	`2001`	`seq_putc(m, '\n');`
`2002`	`2002`
`2003`		`- return seq_has_overflowed(m);`
	`2003`	`+ return 0;`
`2004`	`2004`	`}`
`2005`	`2005`
`2006`	`2006`	`static int smi_ipmb_proc_open(struct inode inode, struct file file)`
`@@ -2023,7 +2023,7 @@ static int smi_version_proc_show(struct seq_file m, void v)`
`2023`	`2023`	`ipmi_version_major(&intf->bmc->id),`
`2024`	`2024`	`ipmi_version_minor(&intf->bmc->id));`
`2025`	`2025`
`2026`		`- return seq_has_overflowed(m);`
	`2026`	`+ return 0;`
`2027`	`2027`	`}`
`2028`	`2028`
`2029`	`2029`	`static int smi_version_proc_open(struct inode inode, struct file file)`
Original file line number	Diff line number	Diff line change
`@@ -3080,7 +3080,7 @@ static int smi_type_proc_show(struct seq_file m, void v)`
`3080`	`3080`
`3081`	`3081`	`seq_printf(m, "%s\n", si_to_str[smi->si_type]);`
`3082`	`3082`
`3083`		`- return seq_has_overflowed(m);`
	`3083`	`+ return 0;`
`3084`	`3084`	`}`
`3085`	`3085`
`3086`	`3086`	`static int smi_type_proc_open(struct inode inode, struct file file)`
`@@ -3153,7 +3153,7 @@ static int smi_params_proc_show(struct seq_file m, void v)`
`3153`	`3153`	`smi->irq,`
`3154`	`3154`	`smi->slave_addr);`
`3155`	`3155`
`3156`		`- return seq_has_overflowed(m);`
	`3156`	`+ return 0;`
`3157`	`3157`	`}`
`3158`	`3158`
`3159`	`3159`	`static int smi_params_proc_open(struct inode inode, struct file file)`
Original file line number	Diff line number	Diff line change
`@@ -1200,7 +1200,7 @@ static int smi_type_proc_show(struct seq_file m, void v)`
`1200`	`1200`	`{`
`1201`	`1201`	`seq_puts(m, "ssif\n");`
`1202`	`1202`
`1203`		`- return seq_has_overflowed(m);`
	`1203`	`+ return 0;`
`1204`	`1204`	`}`
`1205`	`1205`
`1206`	`1206`	`static int smi_type_proc_open(struct inode inode, struct file file)`