Skip to content

Commit 5ff22e7

Browse files
NwPKrausebonzini
authored andcommitted
KVM: x86: Remove FIXMEs in emulate.c for the function,task_switch_32
Remove FIXME comments about needing fault addresses to be returned. These are propaagated from walk_addr_generic to gva_to_gpa and from there to ops->read_std and ops->write_std. Signed-off-by: Nicholas Krause <xerofoify@gmail.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 19d5f10 commit 5ff22e7

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

arch/x86/kvm/emulate.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2750,7 +2750,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
27502750
ret = ops->read_std(ctxt, old_tss_base, &tss_seg, sizeof tss_seg,
27512751
&ctxt->exception);
27522752
if (ret != X86EMUL_CONTINUE)
2753-
/* FIXME: need to provide precise fault address */
27542753
return ret;
27552754

27562755
save_state_to_tss32(ctxt, &tss_seg);
@@ -2759,13 +2758,11 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
27592758
ret = ops->write_std(ctxt, old_tss_base + eip_offset, &tss_seg.eip,
27602759
ldt_sel_offset - eip_offset, &ctxt->exception);
27612760
if (ret != X86EMUL_CONTINUE)
2762-
/* FIXME: need to provide precise fault address */
27632761
return ret;
27642762

27652763
ret = ops->read_std(ctxt, new_tss_base, &tss_seg, sizeof tss_seg,
27662764
&ctxt->exception);
27672765
if (ret != X86EMUL_CONTINUE)
2768-
/* FIXME: need to provide precise fault address */
27692766
return ret;
27702767

27712768
if (old_tss_sel != 0xffff) {
@@ -2776,7 +2773,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
27762773
sizeof tss_seg.prev_task_link,
27772774
&ctxt->exception);
27782775
if (ret != X86EMUL_CONTINUE)
2779-
/* FIXME: need to provide precise fault address */
27802776
return ret;
27812777
}
27822778

0 commit comments

Comments
 (0)