tee: optee: Fix unsigned comparison with less than zero

YueHaibing · arndb · commit 62ade1bed27c · 2019-02-20T17:57:47.000+01:00
The return from the call to tee_client_invoke_func can be a negative error code however this is being assigned to an unsigned variable 'ret' hence the check is always false. Fix this by making 'ret' an int. Detected by Coccinelle ("Unsigned expression compared with zero: ret < 0") Fixes: c3fa24a ("tee: optee: add TEE bus device enumeration support") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Sumit Garg <sumit.garg@linaro.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c
@@ -34,7 +34,7 @@ static int optee_ctx_match(struct tee_ioctl_version_data *ver, const void *data)
 static int get_devices(struct tee_context *ctx, u32 session,
 		       struct tee_shm *device_shm, u32 *shm_size)
 {
-	u32 ret = 0;
+	int ret = 0;
 	struct tee_ioctl_invoke_arg inv_arg;
 	struct tee_param param[4];
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ static int optee_ctx_match(struct tee_ioctl_version_data ver, const void data)`
`34`	`34`	`static int get_devices(struct tee_context *ctx, u32 session,`
`35`	`35`	`struct tee_shm device_shm, u32 shm_size)`
`36`	`36`	`{`
`37`		`- u32 ret = 0;`
	`37`	`+ int ret = 0;`
`38`	`38`	`struct tee_ioctl_invoke_arg inv_arg;`
`39`	`39`	`struct tee_param param[4];`
`40`	`40`