Skip to content

Commit 62d2a19

Browse files
Chengguang Xuaxboe
authored andcommitted
block: remove unnecessary condition check
kmem_cache_destroy() can handle NULL pointer correctly, so there is no need to check e->icq_cache before calling kmem_cache_destroy(). Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 46cb52a commit 62d2a19

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

block/elevator.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -895,8 +895,7 @@ int elv_register(struct elevator_type *e)
895895
spin_lock(&elv_list_lock);
896896
if (elevator_find(e->elevator_name, e->uses_mq)) {
897897
spin_unlock(&elv_list_lock);
898-
if (e->icq_cache)
899-
kmem_cache_destroy(e->icq_cache);
898+
kmem_cache_destroy(e->icq_cache);
900899
return -EBUSY;
901900
}
902901
list_add_tail(&e->list, &elv_list);

0 commit comments

Comments
 (0)