checkpatch: emit an error when using predefined timestamp macros

JoePerches · torvalds · commit 62ec818f55cc · 2015-02-13T21:21:39.000-08:00
Since commit fe7c36c ("Makefile: Build with -Werror=date-time if the compiler supports it"), use of __DATE__, __TIME__, and __TIMESTAMP__ has not been allowed. As this test is gcc version specific (> 4.9), it hasn't prevented a few new uses from creeping into the kernel sources. Make checkpatch complain about them. Signed-off-by: Joe Perches <joe@perches.com> Original-patch-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -5089,6 +5089,12 @@ sub process {
 			}
 		}
 
+# check for uses of __DATE__, __TIME__, __TIMESTAMP__
+		while ($line =~ /\b(__(?:DATE|TIME|TIMESTAMP)__)\b/g) {
+			ERROR("DATE_TIME",
+			      "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr);
+		}
+
 # check for use of yield()
 		if ($line =~ /\byield\s*\(\s*\)/) {
 			WARN("YIELD",

Original file line number	Diff line number	Diff line change
`@@ -5089,6 +5089,12 @@ sub process {`
`5089`	`5089`	`}`
`5090`	`5090`	`}`
`5091`	`5091`
	`5092`	`+# check for uses of __DATE__, __TIME__, __TIMESTAMP__`
	`5093`	`+ while ($line =~ /\b(__(?:DATE\|TIME\|TIMESTAMP)__)\b/g) {`
	`5094`	`+ ERROR("DATE_TIME",`
	`5095`	`+ "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr);`
	`5096`	`+ }`
	`5097`	`+`
`5092`	`5098`	`# check for use of yield()`
`5093`	`5099`	`if ($line =~ /\byield\s\(\s\)/) {`
`5094`	`5100`	`WARN("YIELD",`