Skip to content

Commit 6416f17

Browse files
Sandor YuNitin Garg
authored andcommitted
MLK-10117-3:csi: remove runtime suspend/resume function
CSI v4l2 capture driver have involved to generic pm domain, runtime_suspend/resume function will been called when system suspend/resume. It will cause request_bus_freq/release_bus_freq called counter mismatch. So move request_bus_freq/release_bus_freq function to device open/close function. Signed-off-by: Sandor Yu <R01008@freescale.com>
1 parent 9138e76 commit 6416f17

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

drivers/media/platform/mxc/subdev/mx6s_capture.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1063,6 +1063,8 @@ static int mx6s_csi_open(struct file *file)
10631063

10641064
pm_runtime_get_sync(csi_dev->dev);
10651065

1066+
request_bus_freq(BUS_FREQ_HIGH);
1067+
10661068
mx6s_csi_init(csi_dev);
10671069

10681070
mutex_unlock(&csi_dev->lock);
@@ -1090,6 +1092,8 @@ static int mx6s_csi_close(struct file *file)
10901092

10911093
file->private_data = NULL;
10921094

1095+
release_bus_freq(BUS_FREQ_HIGH);
1096+
10931097
pm_runtime_put_sync_suspend(csi_dev->dev);
10941098
return 0;
10951099
}
@@ -1701,22 +1705,14 @@ static int mx6s_csi_remove(struct platform_device *pdev)
17011705
#ifdef CONFIG_PM_RUNTIME
17021706
static int mx6s_csi_runtime_suspend(struct device *dev)
17031707
{
1704-
int ret = 0;
1705-
1706-
release_bus_freq(BUS_FREQ_HIGH);
17071708
dev_dbg(dev, "csi v4l2 busfreq high release.\n");
1708-
1709-
return ret;
1709+
return 0;
17101710
}
17111711

17121712
static int mx6s_csi_runtime_resume(struct device *dev)
17131713
{
1714-
int ret = 0;
1715-
1716-
request_bus_freq(BUS_FREQ_HIGH);
17171714
dev_dbg(dev, "csi v4l2 busfreq high request.\n");
1718-
1719-
return ret;
1715+
return 0;
17201716
}
17211717
#else
17221718
#define mx6s_csi_runtime_suspend NULL

0 commit comments

Comments
 (0)