Skip to content

Commit 6533b7c

Browse files
chleroympe
authored andcommitted
powerpc: Initial stack protector (-fstack-protector) support
Partialy copied from commit c743f38 ("ARM: initial stack protector (-fstack-protector) support") This is the very basic stuff without the changing canary upon task switch yet. Just the Kconfig option and a constant canary value initialized at boot time. Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent d0563a1 commit 6533b7c

File tree

4 files changed

+51
-0
lines changed

4 files changed

+51
-0
lines changed

arch/powerpc/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ config PPC
163163
select HAVE_VIRT_CPU_ACCOUNTING
164164
select HAVE_ARCH_HARDENED_USERCOPY
165165
select HAVE_KERNEL_GZIP
166+
select HAVE_CC_STACKPROTECTOR
166167

167168
config GENERIC_CSUM
168169
def_bool CPU_LITTLE_ENDIAN
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
/*
2+
* GCC stack protector support.
3+
*
4+
* Stack protector works by putting predefined pattern at the start of
5+
* the stack frame and verifying that it hasn't been overwritten when
6+
* returning from the function. The pattern is called stack canary
7+
* and gcc expects it to be defined by a global variable called
8+
* "__stack_chk_guard" on PPC. This unfortunately means that on SMP
9+
* we cannot have a different canary value per task.
10+
*/
11+
12+
#ifndef _ASM_STACKPROTECTOR_H
13+
#define _ASM_STACKPROTECTOR_H
14+
15+
#include <linux/random.h>
16+
#include <linux/version.h>
17+
#include <asm/reg.h>
18+
19+
extern unsigned long __stack_chk_guard;
20+
21+
/*
22+
* Initialize the stackprotector canary value.
23+
*
24+
* NOTE: this must only be called from functions that never return,
25+
* and it must always be inlined.
26+
*/
27+
static __always_inline void boot_init_stack_canary(void)
28+
{
29+
unsigned long canary;
30+
31+
/* Try to get a semi random initial value. */
32+
get_random_bytes(&canary, sizeof(canary));
33+
canary ^= mftb();
34+
canary ^= LINUX_VERSION_CODE;
35+
36+
current->stack_canary = canary;
37+
__stack_chk_guard = current->stack_canary;
38+
}
39+
40+
#endif /* _ASM_STACKPROTECTOR_H */

arch/powerpc/kernel/Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
1919
CFLAGS_btext.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
2020
CFLAGS_prom.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
2121

22+
# -fstack-protector triggers protection checks in this code,
23+
# but it is being used too early to link to meaningful stack_chk logic.
24+
CFLAGS_prom_init.o += $(call cc-option, -fno-stack-protector)
25+
2226
ifdef CONFIG_FUNCTION_TRACER
2327
# Do not trace early boot code
2428
CFLAGS_REMOVE_cputable.o = -mno-sched-epilog $(CC_FLAGS_FTRACE)

arch/powerpc/kernel/process.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,12 @@
6464
#include <linux/kprobes.h>
6565
#include <linux/kdebug.h>
6666

67+
#ifdef CONFIG_CC_STACKPROTECTOR
68+
#include <linux/stackprotector.h>
69+
unsigned long __stack_chk_guard __read_mostly;
70+
EXPORT_SYMBOL(__stack_chk_guard);
71+
#endif
72+
6773
/* Transactional Memory debug */
6874
#ifdef TM_DEBUG_SW
6975
#define TM_DEBUG(x...) printk(KERN_INFO x)

0 commit comments

Comments
 (0)