Skip to content

Commit 6552580

Browse files
author
Steve French
committed
cifs: minor documentation updates
Also updated a comment describing use of the GlobalMid_Lock Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent d44d137 commit 6552580

File tree

3 files changed

+25
-13
lines changed

3 files changed

+25
-13
lines changed

Documentation/filesystems/cifs/TODO

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ negotiated size) and send larger write sizes to modern servers.
111111

112112
5) Continue to extend the smb3 "buildbot" which does automated xfstesting
113113
against Windows, Samba and Azure currently - to add additional tests and
114-
to allow the buildbot to execute the tests faster.
114+
to allow the buildbot to execute the tests faster. The URL for the
115+
buildbot is: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com
115116

116117
6) Address various coverity warnings (most are not bugs per-se, but
117118
the more warnings are addressed, the easier it is to spot real
Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
This is the client VFS module for the SMB3 NAS protocol as well
2-
older dialects such as the Common Internet File System (CIFS)
2+
as for older dialects such as the Common Internet File System (CIFS)
33
protocol which was the successor to the Server Message Block
44
(SMB) protocol, the native file sharing mechanism for most early
55
PC operating systems. New and improved versions of CIFS are now
6-
called SMB2 and SMB3. These dialects are also supported by the
7-
CIFS VFS module. CIFS is fully supported by network
8-
file servers such as Windows 2000, 2003, 2008, 2012 and 2016
9-
as well by Samba (which provides excellent CIFS
10-
server support for Linux and many other operating systems), Apple
11-
systems, as well as most Network Attached Storage vendors, so
12-
this network filesystem client can mount to a wide variety of
13-
servers.
6+
called SMB2 and SMB3. Use of SMB3 (and later, including SMB3.1.1)
7+
is strongly preferred over using older dialects like CIFS due to
8+
security reaasons. All modern dialects, including the most recent,
9+
SMB3.1.1 are supported by the CIFS VFS module. The SMB3 protocol
10+
is implemented and supported by all major file servers
11+
such as all modern versions of Windows (including Windows 2016
12+
Server), as well as by Samba (which provides excellent
13+
CIFS/SMB2/SMB3 server support and tools for Linux and many other
14+
operating systems). Apple systems also support SMB3 well, as
15+
do most Network Attached Storage vendors, so this network
16+
filesystem client can mount to a wide variety of systems.
17+
It also supports mounting to the cloud (for example
18+
Microsoft Azure), including the necessary security features.
1419

1520
The intent of this module is to provide the most advanced network
1621
file system function for SMB3 compliant servers, including advanced
@@ -24,12 +29,17 @@
2429
cluster file systems for fileserving in some Linux to Linux environments,
2530
not just in Linux to Windows (or Linux to Mac) environments.
2631

27-
This filesystem has an mount utility (mount.cifs) that can be obtained from
32+
This filesystem has a mount utility (mount.cifs) and various user space
33+
tools (including smbinfo and setcifsacl) that can be obtained from
2834

29-
https://ftp.samba.org/pub/linux-cifs/cifs-utils/
35+
https://git.samba.org/?p=cifs-utils.git
36+
or
37+
git://git.samba.org/cifs-utils.git
3038

31-
It must be installed in the directory with the other mount helpers.
39+
mount.cifs should be installed in the directory with the other mount helpers.
3240

3341
For more information on the module see the project wiki page at
3442

43+
https://wiki.samba.org/index.php/LinuxCIFS
44+
and
3545
https://wiki.samba.org/index.php/LinuxCIFS_utils

fs/cifs/cifsglob.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1738,6 +1738,7 @@ require use of the stronger protocol */
17381738
* GlobalMid_Lock protects:
17391739
* list operations on pending_mid_q and oplockQ
17401740
* updates to XID counters, multiplex id and SMB sequence numbers
1741+
* list operations on global DnotifyReqList
17411742
* tcp_ses_lock protects:
17421743
* list operations on tcp and SMB session lists
17431744
* tcon->open_file_lock protects the list of open files hanging off the tcon

0 commit comments

Comments
 (0)