net: bnxt: Fix a uninitialized variable warning.

xiongzhongjiang · davem330 · commit 65fac4fe9080 · 2018-09-18T20:04:40.000-07:00
Fix the following compile warning:

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:49:5: warning: �nvm_param.dir_type� may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (nvm_param.dir_type == BNXT_NVM_PORT_CFG)

Signed-off-by: zhong jiang &lt;zhongjiang@huawei.com&gt;
Acked-by: Michael Chan &lt;michael.chan@broadcom.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -46,6 +46,9 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
 		}
 	}
 
+	if (i == ARRAY_SIZE(nvm_params))
+		return -EOPNOTSUPP;
+
 	if (nvm_param.dir_type == BNXT_NVM_PORT_CFG)
 		idx = bp->pf.port_id;
 	else if (nvm_param.dir_type == BNXT_NVM_FUNC_CFG)

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,9 @@ static int bnxt_hwrm_nvm_req(struct bnxt bp, u32 param_id, void msg,`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
	`49`	`+ if (i == ARRAY_SIZE(nvm_params))`
	`50`	`+ return -EOPNOTSUPP;`
	`51`	`+`
`49`	`52`	`if (nvm_param.dir_type == BNXT_NVM_PORT_CFG)`
`50`	`53`	`idx = bp->pf.port_id;`
`51`	`54`	`else if (nvm_param.dir_type == BNXT_NVM_FUNC_CFG)`