configfs: Fix inconsistent use of file_inode() vs file->f_path.dentry->d_inode

dhowells · Al Viro · commit 6683de3886a3 · 2015-04-15T15:05:31.000-04:00
Fix inconsistent use of file_inode() vs file-&gt;f_path.dentry-&gt;d_inode.

Reported-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: David Howells &lt;dhowells@redhat.com&gt;
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
@@ -1598,7 +1598,7 @@ static loff_t configfs_dir_lseek(struct file *file, loff_t offset, int whence)
 			if (offset >= 0)
 				break;
 		default:
-			mutex_unlock(&file_inode(file)->i_mutex);
+			mutex_unlock(&dentry->d_inode->i_mutex);
 			return -EINVAL;
 	}
 	if (offset != file->f_pos) {

Original file line number	Diff line number	Diff line change
`@@ -1598,7 +1598,7 @@ static loff_t configfs_dir_lseek(struct file *file, loff_t offset, int whence)`
`1598`	`1598`	`if (offset >= 0)`
`1599`	`1599`	`break;`
`1600`	`1600`	`default:`
`1601`		`- mutex_unlock(&file_inode(file)->i_mutex);`
	`1601`	`+ mutex_unlock(&dentry->d_inode->i_mutex);`
`1602`	`1602`	`return -EINVAL;`
`1603`	`1603`	`}`
`1604`	`1604`	`if (offset != file->f_pos) {`