livepatch: Add a missing newline character in klp_module_coming()

Zhen Lei · pmladek · commit 66d8529d0f04 · 2022-09-01T16:27:59.000+02:00
The error message is not printed immediately because it does not end with a newline character. Before: root@localhost:~# insmod vmlinux.ko insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters After: root@localhost:~# insmod vmlinux.ko [ 43.982558] livepatch: vmlinux.ko: invalid module name insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters Fixes: dcf550e ("livepatch: Disallow vmlinux.ko") Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Reviewed-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20220830112855.749-1-thunder.leizhen@huawei.com
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
@@ -1171,7 +1171,7 @@ int klp_module_coming(struct module *mod)
 		return -EINVAL;
 
 	if (!strcmp(mod->name, "vmlinux")) {
-		pr_err("vmlinux.ko: invalid module name");
+		pr_err("vmlinux.ko: invalid module name\n");
 		return -EINVAL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1171,7 +1171,7 @@ int klp_module_coming(struct module *mod)`
`1171`	`1171`	`return -EINVAL;`
`1172`	`1172`
`1173`	`1173`	`if (!strcmp(mod->name, "vmlinux")) {`
`1174`		`- pr_err("vmlinux.ko: invalid module name");`
	`1174`	`+ pr_err("vmlinux.ko: invalid module name\n");`
`1175`	`1175`	`return -EINVAL;`
`1176`	`1176`	`}`
`1177`	`1177`