Skip to content

Commit 67d34a6

Browse files
rostedtmichal42
authored andcommitted
kconfig: Document oldnoconfig to what it really does
The make target 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but instead sets it to their default values. Unfortunately, assuming that it actually did this, broke ktest in some of its tests. For example, the tests to create a minimum config and even a config bisect, depends on removing various configs and using oldnoconfig to get rid of other configs that may have depended on it. But because some configs that it was trying to disable, were in fact default enabled, this caused those configs to re-enable and corrupt the test. I thought about fixing oldnoconfig, but I'm afraid that people are already dependent on its current behavior. Instead, I'm just updating the documentation to state that it sets the new symbols to their default values and not to 'n'. Ideally, this would be called, 'olddefconfig' and we have an 'oldnoconfig' that actually disables the new symbols. But it's useless for me now. If it changed, ktest would need to be consistent between each version, and that would be to difficult to detect. I'll handle this issue with ktest with other means. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Michal Marek <mmarek@suse.cz>
1 parent d68e818 commit 67d34a6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/kconfig/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ help:
114114
@echo ' alldefconfig - New config with all symbols set to default'
115115
@echo ' randconfig - New config with random answer to all options'
116116
@echo ' listnewconfig - List new options'
117-
@echo ' oldnoconfig - Same as silentoldconfig but set new symbols to n (unset)'
117+
@echo ' oldnoconfig - Same as silentoldconfig but sets new symbols to their default value'
118118

119119
# lxdialog stuff
120120
check-lxdialog := $(srctree)/$(src)/lxdialog/check-lxdialog.sh

0 commit comments

Comments
 (0)