mn10300/PCI: Add struct pci_ops member names to initialization

robherring · bjorn-helgaas · commit 68436d139f36 · 2015-01-22T13:57:49.000-06:00
Some instances of pci_ops initialization rely on the read/write members'
location in the struct.  This is fragile and may break when adding new
members to the beginning of the struct.

No functional change.

Signed-off-by: Rob Herring &lt;robh@kernel.org&gt;
Signed-off-by: Bjorn Helgaas &lt;bhelgaas@google.com&gt;
CC: David Howells &lt;dhowells@redhat.com&gt;
CC: Koichi Yasutake &lt;yasutake.koichi@jp.panasonic.com&gt;
CC: linux-am33-list@redhat.com
diff --git a/arch/mn10300/unit-asb2305/pci.c b/arch/mn10300/unit-asb2305/pci.c
@@ -228,8 +228,8 @@ static int pci_ampci_write_config(struct pci_bus *bus, unsigned int devfn,
 }
 
 static struct pci_ops pci_direct_ampci = {
-	pci_ampci_read_config,
-	pci_ampci_write_config,
+	.read = pci_ampci_read_config,
+	.write = pci_ampci_write_config,
 };
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -228,8 +228,8 @@ static int pci_ampci_write_config(struct pci_bus *bus, unsigned int devfn,`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`static struct pci_ops pci_direct_ampci = {`
`231`		`- pci_ampci_read_config,`
`232`		`- pci_ampci_write_config,`
	`231`	`+ .read = pci_ampci_read_config,`
	`232`	`+ .write = pci_ampci_write_config,`
`233`	`233`	`};`
`234`	`234`
`235`	`235`	`/*`