Skip to content

Commit 698733f

Browse files
Dan CarpenterChristoph Hellwig
authored andcommitted
swiotlb: remove an unecessary NULL check
Smatch complains here: lib/swiotlb.c:730 swiotlb_alloc_buffer() warn: variable dereferenced before check 'dev' (see line 716) "dev" isn't ever NULL in this function so we can just remove the check. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 3d6ce86 commit 698733f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/swiotlb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle,
727727

728728
out_unmap:
729729
dev_warn(dev, "hwdev DMA mask = 0x%016Lx, dev_addr = 0x%016Lx\n",
730-
(unsigned long long)(dev ? dev->coherent_dma_mask : 0),
730+
(unsigned long long)dev->coherent_dma_mask,
731731
(unsigned long long)*dma_handle);
732732

733733
/*

0 commit comments

Comments
 (0)