drm/i915/tv: Fix return value for intel_tv_compute_config()

vsyrjala · vsyrjala · commit 6a2a94041052 · 2019-01-28T15:53:32.000+02:00
Ever since commit 204474a ("drm/i915: Pass down rc in intel_encoder->compute_config()") we're supposed to return an errno from .compute_config(). I failed to notice that when pushing the TV encoder fixes which were written before said commmit. Fix up the return value for the error case. Cc: Imre Deak <imre.deak@intel.com> Fixes: 690157f ("drm/i915/tv: Fix >1024 modes on gen3") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190125181931.19482-1-ville.syrjala@linux.intel.com Reviewed-by: Imre Deak <imre.deak@intel.com>
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
@@ -1189,7 +1189,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,
 
 		if (extra < 0) {
 			DRM_DEBUG_KMS("No vertical scaling for >1024 pixel wide modes\n");
-			return false;
+			return -EINVAL;
 		}
 
 		/* Need to turn off the vertical filter and center the image */

Original file line number	Diff line number	Diff line change
`@@ -1189,7 +1189,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,`
`1189`	`1189`
`1190`	`1190`	`if (extra < 0) {`
`1191`	`1191`	`DRM_DEBUG_KMS("No vertical scaling for >1024 pixel wide modes\n");`
`1192`		`- return false;`
	`1192`	`+ return -EINVAL;`
`1193`	`1193`	`}`
`1194`	`1194`
`1195`	`1195`	`/* Need to turn off the vertical filter and center the image */`