Skip to content

Commit 6abd232

Browse files
author
Al Viro
committed
bury generic_file_aio_{read,write}
no callers left Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent b42b15f commit 6abd232

File tree

2 files changed

+8
-37
lines changed

2 files changed

+8
-37
lines changed

include/linux/fs.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2411,10 +2411,8 @@ extern int generic_file_readonly_mmap(struct file *, struct vm_area_struct *);
24112411
extern int generic_file_remap_pages(struct vm_area_struct *, unsigned long addr,
24122412
unsigned long size, pgoff_t pgoff);
24132413
int generic_write_checks(struct file *file, loff_t *pos, size_t *count, int isblk);
2414-
extern ssize_t generic_file_aio_read(struct kiocb *, const struct iovec *, unsigned long, loff_t);
24152414
extern ssize_t generic_file_read_iter(struct kiocb *, struct iov_iter *);
24162415
extern ssize_t __generic_file_write_iter(struct kiocb *, struct iov_iter *);
2417-
extern ssize_t generic_file_aio_write(struct kiocb *, const struct iovec *, unsigned long, loff_t);
24182416
extern ssize_t generic_file_write_iter(struct kiocb *, struct iov_iter *);
24192417
extern ssize_t generic_file_direct_write(struct kiocb *, struct iov_iter *, loff_t);
24202418
extern ssize_t generic_perform_write(struct file *, struct iov_iter *, loff_t);

mm/filemap.c

Lines changed: 8 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1663,6 +1663,14 @@ static ssize_t do_generic_file_read(struct file *filp, loff_t *ppos,
16631663
return written ? written : error;
16641664
}
16651665

1666+
/**
1667+
* generic_file_read_iter - generic filesystem read routine
1668+
* @iocb: kernel I/O control block
1669+
* @iter: destination for the data read
1670+
*
1671+
* This is the "read_iter()" routine for all filesystems
1672+
* that can use the page cache directly.
1673+
*/
16661674
ssize_t
16671675
generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
16681676
{
@@ -1713,28 +1721,6 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
17131721
}
17141722
EXPORT_SYMBOL(generic_file_read_iter);
17151723

1716-
/**
1717-
* generic_file_aio_read - generic filesystem read routine
1718-
* @iocb: kernel I/O control block
1719-
* @iov: io vector request
1720-
* @nr_segs: number of segments in the iovec
1721-
* @pos: current file position
1722-
*
1723-
* This is the "read()" routine for all filesystems
1724-
* that can use the page cache directly.
1725-
*/
1726-
ssize_t
1727-
generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov,
1728-
unsigned long nr_segs, loff_t pos)
1729-
{
1730-
size_t count = iov_length(iov, nr_segs);
1731-
struct iov_iter i;
1732-
1733-
iov_iter_init(&i, READ, iov, nr_segs, count);
1734-
return generic_file_read_iter(iocb, &i);
1735-
}
1736-
EXPORT_SYMBOL(generic_file_aio_read);
1737-
17381724
#ifdef CONFIG_MMU
17391725
/**
17401726
* page_cache_read - adds requested page to the page cache if not already there
@@ -2675,19 +2661,6 @@ ssize_t generic_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
26752661
}
26762662
EXPORT_SYMBOL(generic_file_write_iter);
26772663

2678-
ssize_t generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
2679-
unsigned long nr_segs, loff_t pos)
2680-
{
2681-
size_t count = iov_length(iov, nr_segs);
2682-
struct iov_iter from;
2683-
2684-
BUG_ON(iocb->ki_pos != pos);
2685-
2686-
iov_iter_init(&from, WRITE, iov, nr_segs, count);
2687-
return generic_file_write_iter(iocb, &from);
2688-
}
2689-
EXPORT_SYMBOL(generic_file_aio_write);
2690-
26912664
/**
26922665
* try_to_release_page() - release old fs-specific metadata on a page
26932666
*

0 commit comments

Comments
 (0)