SERIAL: ioc3_serial: Return -ENOMEM on memory allocation failure

Julia Lawall · ralfbaechle · commit 6cc0cc4a3533 · 2010-10-19T18:32:40.000+01:00
In this code, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; expression x,e1,e2,e3; @@ ret = 0 ... when != ret = e1 *x = \(kmalloc\|kcalloc\|kzalloc\)(...) ... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> To: Pat Gefre <pfg@sgi.com> Cc: kernel-janitors@vger.kernel.org Cc: linux-ia64@vger.kernel.org Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/1704/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/drivers/serial/ioc3_serial.c b/drivers/serial/ioc3_serial.c
@@ -2044,6 +2044,7 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd)
 		if (!port) {
 			printk(KERN_WARNING
 			       "IOC3 serial memory not available for port\n");
+			ret = -ENOMEM;
 			goto out4;
 		}
 		spin_lock_init(&port->ip_lock);

Original file line number	Diff line number	Diff line change
`@@ -2044,6 +2044,7 @@ ioc3uart_probe(struct ioc3_submodule is, struct ioc3_driver_data idd)`
`2044`	`2044`	`if (!port) {`
`2045`	`2045`	`printk(KERN_WARNING`
`2046`	`2046`	`"IOC3 serial memory not available for port\n");`
	`2047`	`+ ret = -ENOMEM;`
`2047`	`2048`	`goto out4;`
`2048`	`2049`	`}`
`2049`	`2050`	`spin_lock_init(&port->ip_lock);`