Skip to content

Commit 6d928ae

Browse files
iveceradavem330
authored andcommitted
be2net: don't delete MAC on close on unprivileged BE3 VFs
BE3 VFs without FILTMGMT privilege are not allowed to modify its MAC, VLAN table and UC/MC lists. So don't try to delete MAC on such VFs. Cc: Sathya Perla <sathya.perla@broadcom.com> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Cc: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Ivan Vecera <cera@cera.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent fe68d8b commit 6d928ae

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/net/ethernet/emulex/benet/be_main.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3609,7 +3609,11 @@ static void be_rx_qs_destroy(struct be_adapter *adapter)
36093609

36103610
static void be_disable_if_filters(struct be_adapter *adapter)
36113611
{
3612-
be_dev_mac_del(adapter, adapter->pmac_id[0]);
3612+
/* Don't delete MAC on BE3 VFs without FILTMGMT privilege */
3613+
if (!BEx_chip(adapter) || !be_virtfn(adapter) ||
3614+
check_privilege(adapter, BE_PRIV_FILTMGMT))
3615+
be_dev_mac_del(adapter, adapter->pmac_id[0]);
3616+
36133617
be_clear_uc_list(adapter);
36143618
be_clear_mc_list(adapter);
36153619

0 commit comments

Comments
 (0)