HID: intel-ish-hid: fixes incorrect error handling

SinkFinder · Jiri Kosina · commit 6e0856d31744 · 2018-12-17T15:04:49.000+01:00
The memory chunk allocated by hid_allocate_device() should be released by hid_destroy_device(), not kfree(). Fixes: 0b28cb4("HID: intel-ish-hid: ISH HID client driver") Signed-off-by: Pan Bian <bianpan2016@163.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c
@@ -222,7 +222,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
 err_hid_device:
 	kfree(hid_data);
 err_hid_data:
-	kfree(hid);
+	hid_destroy_device(hid);
 	return rv;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,`
`222`	`222`	`err_hid_device:`
`223`	`223`	`kfree(hid_data);`
`224`	`224`	`err_hid_data:`
`225`		`- kfree(hid);`
	`225`	`+ hid_destroy_device(hid);`
`226`	`226`	`return rv;`
`227`	`227`	`}`
`228`	`228`