scsi: libfc: pass an error pointer to fc_disc_error()

Dan Carpenter · martinkpetersen · commit 6f37e2102778 · 2017-07-12T17:25:12.000-04:00
This patch is basically to silence a static checker warning.

    drivers/scsi/libfc/fc_disc.c:326 fc_disc_error()
    warn: passing a valid pointer to 'PTR_ERR'

It doesn't affect runtime because it treats -ENOMEM and a valid pointer
the same.  But the documentation says we should be passing an error
pointer.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Acked-by: Johannes Thumshirn &lt;jth@kernel.org&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
@@ -573,7 +573,7 @@ static void fc_disc_gpn_ft_resp(struct fc_seq *sp, struct fc_frame *fp,
 		event = DISC_EV_FAILED;
 	}
 	if (error)
-		fc_disc_error(disc, fp);
+		fc_disc_error(disc, ERR_PTR(error));
 	else if (event != DISC_EV_NONE)
 		fc_disc_done(disc, event);
 	fc_frame_free(fp);

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ static void fc_disc_gpn_ft_resp(struct fc_seq sp, struct fc_frame fp,`
`573`	`573`	`event = DISC_EV_FAILED;`
`574`	`574`	`}`
`575`	`575`	`if (error)`
`576`		`- fc_disc_error(disc, fp);`
	`576`	`+ fc_disc_error(disc, ERR_PTR(error));`
`577`	`577`	`else if (event != DISC_EV_NONE)`
`578`	`578`	`fc_disc_done(disc, event);`
`579`	`579`	`fc_frame_free(fp);`