Skip to content

Commit 70ad7f7

Browse files
jonhunterstorulf
authored andcommitted
mmc: tegra: Disable UHS-I modes for Tegra124
Tegra124 has been randomly hanging during system suspend when entering the Tegra LP1 low power state. The hang is caused by the Tegra SDHCI driver and linked to the UHS-I tuning sequence. Disabling the UHS-I modes for Tegra124 prevents any hangs from occurring when entering system suspend. Unfortunately, the tuning sequence described in the public Tegra documentation is incomplete and on inspection of the current tuning sequence that has been implemented is also incomplete and may cause problems. In the short-term it is safer to disable UHS-I modes for now and fix later because it would be too large of a change to simply patch now. Therefore, disable UHS-I modes for Tegra124. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 9aaf343 commit 70ad7f7

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

drivers/mmc/host/sdhci-tegra.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -382,14 +382,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra114 = {
382382
.pdata = &sdhci_tegra114_pdata,
383383
};
384384

385-
static const struct sdhci_tegra_soc_data soc_data_tegra124 = {
386-
.pdata = &sdhci_tegra114_pdata,
387-
.nvquirks = NVQUIRK_ENABLE_SDR50 |
388-
NVQUIRK_ENABLE_DDR50 |
389-
NVQUIRK_ENABLE_SDR104 |
390-
NVQUIRK_HAS_PADCALIB,
391-
};
392-
393385
static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
394386
.quirks = SDHCI_QUIRK_BROKEN_TIMEOUT_VAL |
395387
SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
@@ -407,7 +399,7 @@ static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
407399

408400
static const struct of_device_id sdhci_tegra_dt_match[] = {
409401
{ .compatible = "nvidia,tegra210-sdhci", .data = &soc_data_tegra210 },
410-
{ .compatible = "nvidia,tegra124-sdhci", .data = &soc_data_tegra124 },
402+
{ .compatible = "nvidia,tegra124-sdhci", .data = &soc_data_tegra114 },
411403
{ .compatible = "nvidia,tegra114-sdhci", .data = &soc_data_tegra114 },
412404
{ .compatible = "nvidia,tegra30-sdhci", .data = &soc_data_tegra30 },
413405
{ .compatible = "nvidia,tegra20-sdhci", .data = &soc_data_tegra20 },

0 commit comments

Comments
 (0)