scsi: ufs: Fix error return code in ufshcd_init()

Wei Yongjun · martinkpetersen · commit 73811c942954 · 2016-09-29T21:37:03.000-04:00
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun &lt;weiyongjun1@huawei.com&gt;
Reviewed-by: Subhash Jadavani &lt;subhashj@codeaurora.org&gt;
Reviewed-by: Kiwoong Kim &lt;kwmad.kim@samsung.com&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
@@ -6503,6 +6503,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
 		if (IS_ERR(hba->devfreq)) {
 			dev_err(hba->dev, "Unable to register with devfreq %ld\n",
 					PTR_ERR(hba->devfreq));
+			err = PTR_ERR(hba->devfreq);
 			goto out_remove_scsi_host;
 		}
 		/* Suspend devfreq until the UFS device is detected */

Original file line number	Diff line number	Diff line change
`@@ -6503,6 +6503,7 @@ int ufshcd_init(struct ufs_hba hba, void __iomem mmio_base, unsigned int irq)`
`6503`	`6503`	`if (IS_ERR(hba->devfreq)) {`
`6504`	`6504`	`dev_err(hba->dev, "Unable to register with devfreq %ld\n",`
`6505`	`6505`	`PTR_ERR(hba->devfreq));`
	`6506`	`+ err = PTR_ERR(hba->devfreq);`
`6506`	`6507`	`goto out_remove_scsi_host;`
`6507`	`6508`	`}`
`6508`	`6509`	`/* Suspend devfreq until the UFS device is detected */`