ipv6: Don't pass invalid dst_entry pointer to dst_release().

ostr · davem330 · commit 738faca34335 · 2011-04-04T13:07:26.000-07:00
Make sure dst_release() is not called with error pointer. This is similar to commit 4910ac6 ("ipv4: Don't ip_rt_put() an error pointer in RAW sockets."). Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
@@ -503,6 +503,7 @@ static int tcp_v6_send_synack(struct sock *sk, struct request_sock *req,
 	dst = ip6_dst_lookup_flow(sk, &fl6, final_p, false);
 	if (IS_ERR(dst)) {
 		err = PTR_ERR(dst);
+		dst = NULL;
 		goto done;
 	}
 	skb = tcp_make_synack(sk, dst, req, rvp);

Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,7 @@ static int tcp_v6_send_synack(struct sock sk, struct request_sock req,`
`503`	`503`	`dst = ip6_dst_lookup_flow(sk, &fl6, final_p, false);`
`504`	`504`	`if (IS_ERR(dst)) {`
`505`	`505`	`err = PTR_ERR(dst);`
	`506`	`+ dst = NULL;`
`506`	`507`	`goto done;`
`507`	`508`	`}`
`508`	`509`	`skb = tcp_make_synack(sk, dst, req, rvp);`